Refactor: Abstract the way to handle remote snapshotter #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubin
force-pushed
the
refactor-remote-snapshotter
branch
from
5ebb191 to
58a4e02
Compare
As more and more snapshotter are added, the original processing code is getting longer and longer. By refactoring these processing into an interface, we can do some decoupling and abstraction work to make the code simple and clean. Signed-off-by: bin liu <liubin0329@gmail.com>
liubin
force-pushed
the
refactor-remote-snapshotter
branch
from
58a4e02 to
17771d0
Compare
ktock
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As more and more snapshotter are added, the original processing code
is getting longer and longer. By refactoring these processing into
an interface, we can do some decoupling and abstraction work to make
the code simple and clean.
Related issues:
#609
#603
#1163
Signed-off-by: bin liu liubin0329@gmail.com